minor fix for windows#15
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the Windows PyInstaller --add-data syntax in GitHub Actions workflows so required YAML config files are bundled correctly in the standalone build.
Changes:
- Update Windows PyInstaller
--add-dataseparator from:to;in CI workflow. - Update the corresponding line in the release workflow (but it currently introduces a filename typo).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Adjusts Windows PyInstaller data bundling for release builds (currently broken due to a typo in the config filename). |
| .github/workflows/ci.yml | Fixes Windows PyInstaller --add-data syntax to correctly include loc_config.yaml during CI builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --add-data "image;image" | ||
| --add-data "config.yaml;." | ||
| --add-data "loc_config.yaml:." | ||
| --add-data "loc_config.;." |
There was a problem hiding this comment.
The Windows PyInstaller --add-data entry appears to be corrupted: loc_config.;. drops the .yaml filename and will cause the build to miss loc_config.yaml (and may even be treated as a directory). This should match the Windows syntax used in ci.yml: --add-data "loc_config.yaml;.".
Suggested change
| --add-data "loc_config.;." | |
| --add-data "loc_config.yaml;." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.